On Fri, 8 Aug 2008, Eduardo Habkost wrote: > > I got the following build error on next-20080808: > > fs/nfsctl.c: In function ?do_open?: > fs/nfsctl.c:45: error: implicit declaration of function ?current_cred? > fs/nfsctl.c:45: warning: passing argument 4 of ?dentry_open? makes pointer from integer without a cast > make[1]: *** [fs/nfsctl.o] Error 1 > make: *** [fs/nfsctl.o] Error 2 Something I noticed in the configs posted with build breakages is CONFIG_SMP=n, although I'm not sure how/if that's related. In any case, it seems that linux/cred.h should include linux/sched.h to provide a full definition of 'struct task_struct', so that 'current' can be dereferenced (e.g. in current_cred()). Does this patch work for you and look correct ? ---- diff --git a/fs/nfsctl.c b/fs/nfsctl.c index cc4ef26..f6967b6 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c @@ -14,6 +14,7 @@ #include <linux/namei.h> #include <linux/mount.h> #include <linux/syscalls.h> +#include <linux/cred.h> #include <asm/uaccess.h> /* diff --git a/include/linux/cred.h b/include/linux/cred.h index b156ed4..431f1ab 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h @@ -14,9 +14,9 @@ #include <linux/capability.h> #include <linux/key.h> +#include <linux/sched.h> #include <asm/atomic.h> -struct user_struct; struct cred; struct inode; --- Signed-off-by: James Morris <jmorris@xxxxxxxxx> -- James Morris <jmorris@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
