Hi Stephen, Good catch, my apologies. -Kevin -----Original Message----- From: Stephen Rothwell [mailto:sfr@xxxxxxxxxxxxxxxx] Sent: Wednesday, August 06, 2008 5:53 PM To: Greg KH Cc: linux-next@xxxxxxxxxxxxxxx; Kevin Lloyd Subject: linux-next: usb.current tree build failure Hi Greg, Today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from drivers/usb/storage/usb.c:177: drivers/usb/storage/unusual_devs.h:1577: error: 'sierra_ms_init' undeclared here (not in a function) Caused by commit ff28a24426410aa193b47a5e9ec091d46eaa66d1 ("USB Storage Sierra: TRU-Install feature update"). I applied the following patch. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/ From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Date: Thu, 7 Aug 2008 10:51:49 +1000 Subject: [PATCH] usb: build fix for sierra_ms unusual device Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> --- drivers/usb/storage/unusual_devs.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 0547853..564999c 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -1569,6 +1569,7 @@ UNUSUAL_DEV( 0x10d6, 0x2200, 0x0100, 0x0100, US_SC_DEVICE, US_PR_DEVICE, NULL, 0), +#ifdef CONFIG_USB_STORAGE_SIERRA /* Reported by Kevin Lloyd <linux@xxxxxxxxxxxxxxxxxx> * Entry is needed for the initializer function override, * which instructs the device to load as a modem @@ -1579,6 +1580,7 @@ UNUSUAL_DEV( 0x1199, 0x0fff, 0x0000, 0x9999, "USB MMC Storage", US_SC_DEVICE, US_PR_DEVICE, sierra_ms_init, 0), +#endif /* Reported by Jaco Kroon <jaco@xxxxxxxxxxx> * The usb-storage module found on the Digitech GNX4 (and supposedly other -- 1.5.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html