On Thu, 31 Jul 2008 08:44:14 +1000 Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2008-07-29 at 12:02 +0200, Joerg Roedel wrote: > > On Tue, Jul 29, 2008 at 06:58:08PM +0900, FUJITA Tomonori wrote: > > > On Tue, 29 Jul 2008 11:50:27 +0200 > > > Joerg Roedel <joerg.roedel@xxxxxxx> wrote: > > > > do you want to work on that or should I try to do this and send it to > > > > you for review? > > > > > > I've already sent a patch that fixes the breakages in such way: > > > > > > http://marc.info/?l=linux-kernel&m=121730644704448&w=2 > > > > Yes I have seen this patch. I meant the patches that introduce something > > like IOMMU_PAGE_SIZE for all architectures so that we can make this > > function generic and move it back to lib/. > > That will not work in the light of some new stuff coming on powerpc in > the future. The iommu page size may/will be dynamic per instance of > iommu. IE, it will be mostly decided at runtime, I don't expect machines > to have multiple iommus of different page sizes off hand but it -can- > happen. You could do something like this: #define IOMMU_PAGE_SIZE power_iommu_page_size But I prefer the current proposal to have the size as an argument. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
