Re: Bug with kernel 2.6.38.8.22

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 22 Apr 2011 07:01:21 +0100
Paul McEnery <pmcenery@xxxxxxxxx> wrote:

> It appears that the ipheth driver requires a trivial patch on kernel >= 2.6.37:
> 
> --- ipheth.c.orig       2011-04-20 15:42:09.810578868 -0400
> +++ ipheth.c    2011-04-20 15:37:33.165341931 -0400
> @@ -63,6 +63,9 @@
>        usb_buffer_free(dev, size, addr, dma)
>  #endif
> +#undef NET_IP_ALIGN
> +#define NET_IP_ALIGN 2
> +
>  #define USB_VENDOR_APPLE        0x05ac
>  #define USB_PRODUCT_IPHETH     0x1290
>  #define USB_PRODUCT_IPHETH_3G   0x1292
> 
> 
> Please can this be included?
> 
> Many thanks.
> Paul.

Redefining NET_IP_ALIGN is not the correct fix.
If the driver requires different alignment, it should define
it's own constant and explain the rationale.

More likely the driver just is written incorrectly, since unaligned
DMA is more difficult for hardware.
--
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux