On Fri, 31 Dec 2010 18:45:26 +0100
Mohsen Hariri <m.hariri@xxxxxxxxx> wrote:
> Hi Stephen,
>
>
> Sky2 driver does not support setting advertised modes when auto
> negotiation is on, it will ignore the provided advertised modes and sets it
> to default capabilities. This patch will allow the driver to support that.
>
>
> --- linux-2.6.37-rc8/drivers/net/sky2.c 2010-12-29 02:05:48.000000000 +0100
> +++ linux-2.6.37-rc8_patched/drivers/net/sky2.c 2010-12-31
> 18:00:03.027779003 +0100
> @@ -3458,7 +3458,7 @@
>
> if (ecmd->autoneg == AUTONEG_ENABLE) {
> sky2->flags |= SKY2_FLAG_AUTO_SPEED;
> - ecmd->advertising = supported;
> + ecmd->advertising &= supported;
> sky2->duplex = -1;
> sky2->speed = -1;
> } else {
>
>
>
> Why is it needed? I upgraded my ethernet connection to 1000Mbps and started
> getting this error mostly when there was a load on the connection:
>
> Dec 31 16:43:46 mohsen-laptop kernel: [96536.030618] sky2 0000:07:00.0:
> error interrupt status=0x80000000
> Dec 31 16:43:46 mohsen-laptop kernel: [96536.030633] sky2 0000:07:00.0:
> eth0: hw error interrupt status 0x8
>
> So I tried to set force the connection to 100Mbps and seems this removes all
> the problems. I did not have access to the other end of my connection so I
> needed to set auto negotiation on while forcing the lower speed, thats why I
> needed this patch.
>
> My test system is:
> 2.6.35-23-generic #37-Ubuntu SMP Fri Nov 5 19:17:11 UTC 2010 i686
> GNU/Linux
> (but the patch is against the latest kernel)
I think you are correct but other drivers seem to do the same thing as
the sky2 driver. Let me do some more investigation first.
--
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
