On Thu, 27 Mar 2008 23:29:18 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote: > > When networking is disabled, powerpc probably should not include > networking header files, nor provide networking related arch > specific functions. OK, I always thought that we didn't like conditional includes and that include files should make themselves safe from being included in unexpected circumstances. In particular, until now these include files have not caused problems ... > For example, I'd recommend that it should not include > linux/etherdevice.h and not emit the of_get_mac_address() function > when CONFIG_NET is not defined. I agree about of_get_mac_address, though. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpciLEcYtXFS.pgp
Description: PGP signature
