On Wed, 20 Jun 2007 14:50:52 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> > Date: Wed, 20 Jun 2007 07:45:17 -0700 > > > On Wed, 20 Jun 2007 15:15:23 +0100 > > "Oliver Cook" <oliver.cook@xxxxxxxxxxx> wrote: > > > > > Hi, > > > > > > In trying to run tc with netem to introduce latency in the lab on a > > > 64bit system I discovered the following bug in get_qdisc_kind in tc.c: > > > > > > snprintf(buf, sizeof(buf), "/usr/lib/tc/q_%s.so", str); > > > > > > The path to the tc qdisc shared objects is hard-coded. On a 64bit system > > > the correct path is /usr/lib64/tc/. > > > > That is a distro choice to change the path on 64bit, not all do. So please > > report it as a bug to the distro, and make them fix their package. > > Stephen, stop this. > > This is perfectly legitimate way to handle 32-bit and 64-bit > libraries present on a system. It is a fine if that is how the distro chooses to do it. Is it part of the LSB? My preference is to get rid of the hard coded path and add an environment variable to override. That is how other hardcoded paths are handled. For netem, there is really no need to make it dynamically loadable, I'll just make it static like other qdisc. -- Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
