David Miller wrote: > From: Patrick McHardy <kaber@xxxxxxxxx> > Date: Thu, 10 May 2007 14:56:39 +0200 > >>I don't see why this is needed, the correct way to use TBF with TSO >>is to specify a larger MTU value, in which case it won't drop TSO >>packets. > > > Why should a user have to know anything in the world about TSO in > order to configure TBF properly? I don't think they should have > to at all. The user shouldn't necessarily, but userspace should. The way I see it the MTU is a fundamental parameter for TBF (the peakrate bucket size) and just because userspace picks a bad default (2000) this is no reason to change the implementation to something that is not really TBF anymore and even affects non-TSO packets _and_ TSO packets even when the MTU is chosen large enough (granted, the first point is an implementation detail). The much better solution would be to let userspace pick an appropriate default value and still let the user override it. - To unsubscribe from this list: send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
