Re: [PATCH] bridge netfilter deadlock avoidance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I tested it and it works fine.
Thanks again.

On 10/31/06, Lior Dotan <liodot@xxxxxxxxx> wrote:
Thanks, I'll give it a shot and see how it goes.

On 10/30/06, Stephen Hemminger <shemminger@xxxxxxxx> wrote:
> Simpler/safer fix would be to avoid generating config bpdu's
> immediately when becoming root bridge, and just let the first hello
> timer tick do that.
>
> Completely untested, I don't have any machines with 2.4 distro's handy.
>
>
> --- linux-2.4.33.3.orig/net/bridge/br_stp.c     2006-10-30 12:46:59.000000000 -0800
> +++ linux-2.4.33.3/net/bridge/br_stp.c  2006-10-30 12:53:59.000000000 -0800
> @@ -140,8 +140,8 @@
>         br->forward_delay = br->bridge_forward_delay;
>         br_topology_change_detection(br);
>         br_timer_clear(&br->tcn_timer);
> -       br_config_bpdu_generation(br);
> -       br_timer_set(&br->hello_timer, jiffies);
> +
> +       br_timer_set(&br->hello_timer, jiffies - br->hello_time);
>  }
>
>  /* called under bridge lock */
>
>
>
> --
> Stephen Hemminger <shemminger@xxxxxxxx>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux