On Wed, 13 Jul 2005, Finn Thain wrote:
> On Sun, 26 Jun 2005, Jeff Garzik wrote:
>
> > Patch looks OK to me. Comments:
> >
> > 1) Either Geert or Ralf can merge this, with my ACK.
> >
> > 2) Would be nice to get it tested on the machines you list as untested.
> >
> > 3) [possible problem in driver, not your changes] I wonder if IRQ_HANDLED is
> > ever returned for shared interrupts? I don't know enough about the platform
> > interrupt architecture to answer this question.
> >
> > 4) Remove casts to/from void. This is especially noticable in all the casts
> > of the netdev_priv() return value.
> >
> > 5) If it doesn't cause too much patch noise, consider using enums rather than
> > #defines, for numeric constants. This gives the compiler more type
> > information and makes the symbols visible in a debugger. This is a
> > -maintainer preference- issue overall, so don't sweat it if you disagree.
>
>
> This patch removes the unecessary void* casts introduced in the first patch.
Update:
The two patches referred to above have been tested on Jazz MIPS and
ack'd off-list by Thomas Bogendorfer. He also added the cosmetic change below.
I think this is ready to be merged (Jeff?)
Roman, is your m68k DMA implementation ready for commit? Thomas will take
care of the Jazz one.
Thanks
-f
Acked-off: by Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
--- jazzsonic.c.orig 2005-08-18 23:15:24.067805832 +0200
+++ jazzsonic.c 2005-08-18 23:18:15.895684024 +0200
@@ -123,7 +123,7 @@
if (sonic_debug && version_printed++ == 0)
printk(version);
- printk("%s: Sonic ethernet found at 0x%08lx, ", lp->device->bus_id, dev->base_addr);
+ printk(KERN_INFO "%s: Sonic ethernet found at 0x%08lx, ", lp->device->bus_id, dev->base_addr);
/*
* Put the sonic into software reset, then
@@ -238,7 +238,7 @@
if (err)
goto out1;
- printk(KERN_INFO "%s: MAC ", dev->name);
+ printk("%s: MAC ", dev->name);
for (i = 0; i < 6; i++) {
printk("%2.2x", dev->dev_addr[i]);
if (i < 5)
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
