On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote: > On 4/30/05, Jesper Juhl <juhl-lkml@xxxxxx> wrote: > > Hi David, > > > > Since Andrew merged the patch that makes calling crypto_free_tfm() with a > > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for > > NULL before calling that function, and while I was at it I removed similar > > redundant checks before calls to kfree() and vfree() in the same files. > > There are also a few tiny whitespace cleanups in there. > > Jesper, I'd suggest that you left whitespaces for a separate patch, it > is always, > IMHO, better to have as small a patch as possible for reviewing. > Sure thing. I've split the patches, and I believe that me going through them a second time did them good, there are a few tiny changes over the first version. I split the patch in 4 parts (will send as replies to this mail) : 1) crypto_free_tfm related changes 2) kfree related changes 3) vfree related changes 4) whitespace changes The whitespace changes ended up fairly bigger than initially. I expanded the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO a lot better than the originals. -- Jesper - : send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
