Re: kernel BUG at net/ipv6/exthdrs_core.c:80!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 23 Apr 2005 00:19:50 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> I was just reading ipv6_skip_exthdr and it occured to me that we can
> get rid of len altogether.  The only place where len is used is to
> check whether the skb has two bytes for ipv6_opt_hdr.  This check
> is done by skb_header_pointer/skb_copy_bits anyway.
> 
> Now it might appear that we've made the code slower by deferring
> the check to skb_copy_bits.  However, this check should not trigger
> in the common case so this is OK.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

This looks great, applied.

Thanks Herbert.
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux