On Fri, Mar 25, 2005 at 10:42:11AM -0800, Roland Dreier wrote:
> Adrian> This can result in indexing in an array with 8 entries the
> Adrian> 10th entry.
>
> Well, not really, since the first 8 entries of the array have every
> 3-bit pattern. So pos3 & 0x07 will always match one of them.
>
> I agree it would be cleaner to make the loop only go up to 7 though.
You either have this (impossible) overflow, or the case l_i == 7 isn't
tested explicitely.
I'd say simply leave it as it is now.
But if noone disagrees, I'm inclined to add a comment.
> - R.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
