[RFC: 2.6 patch] drivers/net/wireless/airo.c: correct a wrong

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



if
Reply-To: 

The Coverity checker correctly noted that this condition can't ever be 
fulfilled.

Can someone understanding this code check whether my guess what this 
should have been was right?

Or should the if get completely dropped?

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c.old	2005-03-22 21:41:37.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/wireless/airo.c	2005-03-22 21:42:01.000000000 +0100
@@ -3440,9 +3440,6 @@
 	/* Make sure we got something */
 	if (rxd.rdy && rxd.valid == 0) {
 		len = rxd.len + 12;
-		if (len < 12 && len > 2048)
-			goto badrx;
-
 		skb = dev_alloc_skb(len);
 		if (!skb) {
 			ai->stats.rx_dropped++;

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux