On Sat, 2005-02-19 at 03:41 -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > > This patch contains the following cleanups: > > - make a needlessly global function static > > - make three needlessly global structs static > > > > Since after moving the now-static stucts to smc-mca.c the file smc-mca.h > > was empty except for two #define's, I've also killed the rest of > > smc-mca.h . > > It looks like the structs should be 'static const', not just 'static'. > > This comment is applicable to similar changes, also. Use 'const' > whenever possible. does that even have meaning in C? In C++ it does, but afaik in C it doesn't. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
