Bitrot in register_binfmt() in fs/exec.c

[Robin Boerdijk <robin_boerdijk@xxxxxxxxx>]

Hi,

As others have noted before me, there is some bitrot in the
register_binfmt() function in fs/exec.c. Does anyone know who the
current maintainer of this code is?

In case the maintainer is reading this, the code in question is this:

int register_binfmt(struct linux_binfmt * fmt)
{
        struct linux_binfmt ** tmp = &formats;

        if (!fmt)
                return -EINVAL;
        if (fmt->next)
                return -EBUSY;
        write_lock(&binfmt_lock);
        while (*tmp) {
                if (fmt == *tmp) {
                        write_unlock(&binfmt_lock);
                        return -EBUSY;
                }
                tmp = &(*tmp)->next;
        }
        fmt->next = formats;
        formats = fmt;
        write_unlock(&binfmt_lock);
        return 0;
}

The tmp pointer here is declared as a struct linux_binfmt ** pointer
but a linux_binfmt * would have sufficed as *tmp is never assigned to. 

Regards,

Robin Boerdijk



	
		
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - You care about security. So do we. 
http://promotions.yahoo.com/new_mail
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html