Re: [DIFF] 2.6.10 add MSI to tg3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	if (pci_enable_msi(tp->pdev))
> +		printk(KERN_WARNING PFX "MSI NOT enabled for %s\n",
> +				tp->pdev->slot_name);
> +	else {
> +		tw32(MSGINT_MODE, MSGINT_MODE_ENABLE);
> +		printk(KERN_INFO PFX "MSI enabled on %s\n",
> +				tp->pdev->slot_name);
> +	}

I'd suggest killing the printks.  The user can easily check whether
the driver is using MSI or not in /proc/interrupts.

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux