On Sun, 21 Nov 2004, Andrew Morton wrote:
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Tue, 16 Nov 2004, Andrew Morton wrote:
> > > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > > > > There's tons of leaks in the hplcance probing code, and it doesn't release
> > > > > he memory region on removal either.
> > > > >
> > > > > Untested patch to fix those issues below:
> > > >
> > > > ping.
> > >
> > > The fix needs a fix:
> >
> > Indeed.
> >
> > And you should remove the definitions of dio_resource_{start,len}(), as they're
> > already defined in linux/dio.h.
> >
>
> But differently. Christoph had:
>
> +#define dio_resource_len(d) \
> + ((d)->resource.end - (d)->resource.start)
>
> but dio.h has:
>
> #define dio_resource_len(d) ((d)->resource.end-(z)->resource.start+1)
>
>
> Which is correct?
The one in linux/dio.h (i.e. incl. +1, cfr. the definitions in
linux/{pci,zorro}.h, too).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
