Re: ipv6_addr_cmp performance patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



One small comment about your patch: It changes the semantics of ipv6_addr_cmp() from returning sort order A <=> B to boolean A != B. This may be fine, but not if there is users of ipv6_addr_cmp() expecting the sort order property.


There's no such users, AFAIK.
David, I'll do some test. Thanks.

Yes, but we could have some. For instance, because I did not have ipv6_addr_cmp() into a userland daemon (I agree, it is not the kernel :-) ), I have implemented my own one into the Quagga's ripngd that must return a sort order. It is used to build incrementely some classes of route which have the same nexthop.


So, even if it is not used yet into the kernel, it is a nice feature that we should keep.

My 2 cents,
  Vincent
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux