Re: [BK PATCH] Fix ip_conntrack_amanda data corruption bug that breaks amanda dumps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 5 Nov 2004, Pablo Neira wrote:

Patrick, what about this? this way we save a copy to a buffer for linear skbs.

You need to make sure you or any of the later string match/extract functions are not reading outside of the skb, after the current data segment.


From what I could tell this was missing in your proposed change. If the
helper sees a packet with a C as last byte it would read past the end of the skb, and without looking at the whole source I see it very likely there is operations on the data further down assuming a null terminated string..

Regards
Henrik
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux