On Fri, 05 Nov 2004 00:53:22 +0100 Patrick McHardy <kaber@trash.net> wrote: > Your observation and your patch were correct, thanks. It is supposed > to be just a copy, I missed that it wasn't anymore. While your patch > works too, and is even faster with non-linear skbs, I don't like the > idea of using the skb as a scratch-area, so I sent this patch to Dave > instead. His patch isn't correct, even making a temporary change to a shared SKB is illegal. Things like tcpdump could see corrupt SKB contents if they look during that tiny window when the newline character has been changed to NULL by the amanda conntrack module. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
