On Tue, Nov 02, 2004 at 01:28:22PM +0100, Thomas Spatzier wrote: > A solution would be, that the stack evaluates error codes returned > by notifier_call_chain. In case of an error, the IP address should be > deleted from the device's ifa_list. With all due respect, if your card has a problem receiving packets for a particular IP, that your card/driver's problem. Are these errors anything the user can do about? Besides, if you have multiple network cards, you can still receive connections for that IP from other network ports, so it'd be wrong to have all them stop working just because your card is having an issue. > Besides, this mis-behaviour of ignoring error codes exists for all > kinds of net device events, for both IPv4 and IPv6. IMHO this should > be changed; why do we have return codes if nobody cares about > them??? I think the reason is that there is no reason why adding an IP should fail. I imagine quite a few program don't check because realistically how could it fail. The IP is a property of the network stack (fully software) and thus can't fail. The hardware should not be an issue. > Any comments? What's the failure mode anyway? -- Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a > tool for doing 5% of the work and then sitting around waiting for someone > else to do the other 95% so you can sue them.
Attachment:
pgpTh5WETERMo.pgp
Description: PGP signature
