2.6.9 failed assertion in tcp_timer.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just upgraded 3 heavily used squid boxes to 2.6.9 today from
2.6.8.1, and all started panicing with the same error (usually
within an hour of uptime):

KERNEL: assertion (!skb_queue_empty(&sk->sk_write_queue)) \
	failed at net/ipv4/tcp_timer.c (322)

I note that between 2.6.8.1 and 2.6.9, there was a change 
made to this code:

http://linux.bkbits.net:8080/linux-2.5/diffs/net/ipv4/tcp_timer.c@1.24?nav=index.html|src/.|src/net|src/net/ipv4|hist/net/ipv4/tcp_timer.c

With the relevant portion seeming to be:

@@ -316,7 +316,7 @@
 {
 	struct tcp_opt *tp = tcp_sk(sk);
 
-	if (tp->packets_out == 0)
+	if (!tcp_get_pcount(&tp->packets_out))
 		goto out;
 
 	BUG_TRAP(!skb_queue_empty(&sk->sk_write_queue));


These are all fairly vanilla Dell 2550 boxes with a single E100 nic,
but as noted they are heavily used.

Any additional information needed on this?

Phil

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux