Re: [PATCH 2.6.9-rc3] olympic driver: fix kernel oops on lobe fault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > Neil Horman <nhorman@redhat.com> wrote:
> >>and it fixes the oops that olympic driver encounters when it gets a lobe fault.
> >>I've tested it, with good results.
> > 
> > 
> > The above is relevant, but is quite insufficient.
> > 
> > - What oops does it fix?
> > 
> > - How does it fix it?
> 
> 
> unsufficient for what?

For me?  The patch makes a significant number of unrelated and non-trivial
changes and they are wholly undescribed.

Apart from the time wastage, this practise results in lower code quality. 
We want to hear what the programmer thinks the patch does so we're in a
better position to confirm that it does indeed do that.
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux