Re: [2.6 patch] net/seeq8005.c: small cleanups (fwd)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 11, 2004 at 02:25:46PM -0400, Jeff Garzik wrote:
>...
> >-static const char version[] =
> >-	"seeq8005.c:v1.00 8/07/95 Hamish Coleman 
> >(hamish@zot.apana.org.au)\n";
>...
> >-	if (net_debug  &&  version_printed++ == 0)
> >-		printk(version);
>...
> This "small cleanup" appears to kill useful and working code.

I'd agree if this was a version number that was regularly updated.

But when is a 9 year old version tag useful?

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux