On Sun, Aug 01, 2004 at 01:21:22PM +0200, Jesper Juhl wrote: >... > Wouldn't it make sense to also un-inline hamachi_tx? both the _rx and _tx My primary goal was to fix the compilation with gcc 3.4, not to evaluate all inlines (which is also a good thing to do). > functions are quite big - are they really suitable to be inlined? Each of thamachi_{tx,rx} has exacly one caller, which might be a reason in favor of inlining. > Here's a proposed patch against 2.6.8-rc2-mm1 >... Looks good. > /Jesper Juhl cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html