On Mon, 24 May 2004 21:47:51 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote: > Hence the problem is still a bug in the ref counting. I think I've found > the real culprit now. __xfrm?_find_acq() is missing an xfrm_state_hold > on the create path. This also explains why I never see it myself since > Openswan never creates states through that code-path. Applied, thanks Herbert. How the heck are you generating your patches? Because the file paths look like this in the patch: --- 1.6/net/ipv4/xfrm4_state.c 2003-07-21 21:49:43 +10:00 +++ edited/xfrm4_state.c 2004-05-24 21:41:29 +10:00 My auto-patch-application scripts explode since the path depth of the file is different in the second line there. How come it doesn't look like: --- 1.6/net/ipv4/xfrm4_state.c 2003-07-21 21:49:43 +10:00 +++ edited/net/ipv4/xfrm4_state.c 2004-05-24 21:41:29 +10:00 So that I can throw "-p1" to tools like diffstat and get sane output? Your patches never did this in the past :-) - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html