Re: [RFT] TCP Westwood+ for 2.6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comments below, about missing tcp_ prefixes.

Em Fri, Jan 30, 2004 at 04:47:47PM -0800, Stephen Hemminger escreveu:
> +/* @westwood_update_rttmin
> + * It is used to update RTTmin. In this case we MUST NOT use
> + * WESTWOOD_RTT_MIN minimum bound since we could be on a LAN!
> + */
> +static inline __u32 westwood_update_rttmin(struct sock *sk)

s/westwood_update_rttmin/tcp_westwood_update_rttmin/g

> +static inline __u32 westwood_acked(struct sock *sk)

ditto

> +/*
> + * @westwood_new_window
> + * It evaluates if we are receiving data inside the same RTT window as
> + * when we started.
> + * Return value:
> + * It returns 0 if we are still evaluating samples in the same RTT
> + * window, 1 if the sample has to be considered in the next window.
> + */
> +static int westwood_new_window(struct sock *sk)

ditto

> + * @westwood_update_window
> + * It updates RTT evaluation window if it is the right moment to do
> + * it. If so it calls filter for evaluating bandwidth. Be careful
> + * about __westwood_update_window() since it is called without
> + * any form of lock. It should be used only for internal purposes.
> + * Call westwood_update_window() instead.
> + */
> +static void __westwood_update_window(struct sock *sk, __u32 now)

ditto

> +static void westwood_update_window(struct sock *sk, __u32 now)

ditto

> +/*
> + * @__westwood_fast_bw

ditto

> + * It is called when we are in fast path. In particular it is called when
> + * header prediction is successfull. In such case infact update is
> + * straight forward and doesn't need any particular care.
> + */
> +void __tcp_westwood_fast_bw(struct sock *sk, struct sk_buff *skb)

here it doesn't match the kerneldoc comment, but its right 8)

There are many more below.

- Arnaldo

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux