On Thu, Sep 25, 2003 at 04:28:59PM +0400, kuznet@ms2.inr.ac.ru wrote: > > > In future if we can make sure that mac_len is right before netif_rx > > ... _before_ netif_rx. I see now, I misread your statement before. > Well, maybe it makes sense just to search and replace all changes > done to skb->mac with some macros. Taking into account that for lots of devices > it is inside *_type_trans, there exist not so much of such places. A quick grep shows just below 100 occurances of mac.raw under drivers/net. I'll have a go at it unless someone else does it first. On the other hand, I've found a way to avoid the move without requiring mac_len to be set at all. We can do this in netif_rx: if (mac_len == 0) mac_len = nh - raw And in xfrm_rcv we can do if (mac_len == 0) raw = data Cheers, -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
