-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sat, 20 Sep 2003 00:30:25 -0700 "David S. Miller" <davem@redhat.com> wrote: >On Fri, 19 Sep 2003 19:06:11 +0200 >"Angelo Dell'Aera" <buffer@antifork.org> wrote: > >> - while ((pdev = pci_find_device(PCI_VENDOR_ID_SUN, >> + while ((pdev = pci_get_device(PCI_VENDOR_ID_SUN, > >Why? What are these patches doing? > >Never ever send a patch with no description of what the >patch does and why it is doing. > >I'm not applying any of these, you'll have to resubmit >with a proper description attached. > >Thanks. > Well taking a look at drivers/pci/search.c it's staten that pci_find_device() is not to be used anymore since the pci device returned by this function "can disappear at any moment in time". pci_get_device() is similar to pci_find_device() but it is safer since it increments a reference count to the pci_dev. So I thought that this change could be useful, even considering this function is called just at init time. Regards. - -- Angelo Dell'Aera 'buffer' Antifork Research, Inc. http://buffer.antifork.org PGP information in e-mail header -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/bFIspONIzxnBXKIRAoIEAJsHUIgOmphnJng2mzitVvWAXw1jyACZATMj yagWl1ncESm1A9N0rCRp1zk= =UnJv -----END PGP SIGNATURE----- - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
