[PATCH] slip.c: current state cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeff,

Patch against 2.6-test5.

Removes current->state = TASK_RUNNING after calling schedule_timeout, which already guarantees that the task will be TASK_RUNNING.

Also (but I'm not about this one) adds a set_current_state with a memory barrier before calling schedule_timeout.

Please review this last bit and applies if it looks good.

Thanks,

Felipe
--- linux-2.6.0-test5-fwd/drivers/net/slip.c	Mon Sep  8 16:50:58 2003
+++ linux-2.6.0-test5/drivers/net/slip.c	Wed Sep 10 09:45:48 2003
@@ -1389,9 +1389,8 @@
 	 */
 	do {
 		if (busy) {
-			current->state = TASK_INTERRUPTIBLE;
+			set_current_state(TASK_INTERRUPTIBLE);
 			schedule_timeout(HZ / 10);
-			current->state = TASK_RUNNING;
 		}
 
 		busy = 0;

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux