On Tue, 19 Aug 2003 16:18:14 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:
> David S. Miller wrote:
> > Returning from ->close() before the device is really taken
> > down is a bug and is going to cause problems regardless
> > of whether the netdev module refcount is there or not.
>
Do we need to be explicit in the Documentation then?
diff -Nru a/Documentation/networking/driver.txt b/Documentation/networking/driver.txt
--- a/Documentation/networking/driver.txt Tue Aug 19 13:48:42 2003
+++ b/Documentation/networking/driver.txt Tue Aug 19 13:48:42 2003
@@ -82,3 +82,13 @@
1) Any hardware layer address you obtain for your device should
be verified. For example, for ethernet check it with
linux/etherdevice.h:is_valid_ether_addr()
+
+Close/stop guidelines:
+
+1) After the dev->stop routine has been called, the hardware must
+ not receive or transmit any data. All in flight packets must
+ be aborted. If necessary, poll or wait for completion of
+ any reset commands.
+
+2) The dev->stop routine will be called by unregister_netdevice
+ if device is still UP.
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
