On Tue, 22 Jul 2003 14:50:21 -0700 (PDT) Krishna Kumar <krkumar@us.ibm.com> wrote: > I am using sizeof(struct xxx) or __u32, etc in the code, I guess you are > ok with that. This needs some fixes still. First thing, ipv6_devconf is not obtainable from user and has pointers in it which makes usage sloppy. So I would suggest the following: 1) Remove "void *sysctl;" from ipv6_devconf, move it into inet6_dev ie. "void *cnf_sysctl;" update all code users. 2) Move "struct ipv6_devconf" into some linux/*.h ipv6 header usable by users. Use an existing one if possible. Then make sure net/if_inet6.h includes this thing. 3) Change "int" members of struct "ipv6_devconf" to "s32". It's anal and unnecessary on any current platform, but some day with 128-bit computers it might make some difference. :-) Thanks. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
