Daniel, Thank you for your patch. Some comments about it: - I'd rather fix whatever is broken in the current code than going back to spinlocks, as they increase latency and reduce concurrency. In any case, please check your code. I've seen a spinlock in the interrupt handler that may lock the system. - The fix for the transmit code you mention, is about fixing the returned value in case of error? If not, please explain it to me as I don't see any other changes. - Where did you fix a buffer overflow? I submitted to Jeff an updated version just before you sent your e-mail. It incorporates most of your fixes expect for the possible loop-forever. It's more stable that the one in the current kernel tree. Javier Achirica On Fri, 18 Jul 2003, Daniel Ritz wrote: > in 2.4.20+ airo.c is broken and can even kill keventd. this patch fixes it: > - sane locking with spinlocks and irqs disabled instead of the buggy locking > with semaphores > - fix transmit code > - safer unload ordering of disable irq, unregister_netdev, kfree > - fix possible loop-forever bug > - fix a buffer overflow > > a kernel 2.4 version of the patch is tested by some people with good results. > against 2.6.0-test1-bk. please apply. > > > rgds > -daniel - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
