2.4.21 broke pppoe for me. This makes it work again. Is it correct? (please cc any replies) --- drivers/net/eexpress.c.broken Fri Jun 13 10:51:34 2003 +++ drivers/net/eexpress.c Mon Jun 16 22:05:55 2003 @@ -640,7 +640,9 @@ static int eexp_xmit(struct sk_buff *buf, struct net_device *dev) { struct net_local *lp = (struct net_local *)dev->priv; - short length = buf->len; + unsigned short length = (ETH_ZLEN < buf->len) ? buf->len : + ETH_ZLEN; + #ifdef CONFIG_SMP unsigned long flags; #endif @@ -654,7 +656,6 @@ buf = skb_padto(buf, ETH_ZLEN); if(buf == NULL) return 0; - length = buf->len; } disable_irq(dev->irq); Regards, Shane - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html