Re: Possible memory leak in xfrm_policy_insert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



   From: Herbert Xu <herbert@gondor.apana.org.au>
   Date: Sun, 8 Jun 2003 18:42:47 +1000

   On Sun, Jun 01, 2003 at 12:19:51AM -0700, David S. Miller wrote:
   > void flow_cache_flush(struct flowi *key);
   > 
   > It is defined to delete all flow cache entries matching given key.
   > It must be called after the tables that the "flow_resolve_t" callback
   > for this object will search.  This means we'd invoke it from
   > xfrm_policy_kill() or similar.
   
   This appears to be difficult to implement.  How is the flow cache going
   to know what matches a given key when it doesn't know what that key means?
   
You are absolutely right.

   Perhaps a less ambitious version could work.  What about
   
   void flow_cache_flush(void *object);
   
   which deletes all cache entries referring to object?

That's a workable idea.

I'm sorry I haven't found the time to work on this, feel
free to try to cook something up yourself if you want.

I'll be more than happy to review and fixup whatever you
come up with.
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux