Re: [PATCH] Allow del policy by id and get policy by selector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In article <20030607084214.GA14474@gondor.apana.org.au> (at Sat, 7 Jun 2003 18:42:14 +1000), Herbert Xu <herbert@gondor.apana.org.au> says:

> @@ -790,7 +790,8 @@
>  struct xfrm_policy *xfrm_policy_alloc(int gfp);
>  extern int xfrm_policy_walk(int (*func)(struct xfrm_policy *, int, int, void*), void *);
>  int xfrm_policy_insert(int dir, struct xfrm_policy *policy, int excl);
> -struct xfrm_policy *xfrm_policy_delete(int dir, struct xfrm_selector *sel);
> +struct xfrm_policy *xfrm_policy_bysel(int dir, struct xfrm_selector *sel,
> +				      int delete);
>  struct xfrm_policy *xfrm_policy_byid(int dir, u32 id, int delete);
>  void xfrm_policy_flush(void);
>  u32 xfrm_get_acqseq(void);

Hmm, I don't like the naming...

struct xfrm_policy *__xfrm_policy_bysel(int dir, struct xfrm_selector *sel,
                                        int delete);

static inline struct xfrm_policy *
xfrm_policy_delete(int dir, struct xfrm_selector *sel) {
   return __xfrm_policy_bysel(dir, sel, 1);
}

static inline struct xfrm_policy *
xfrm_policy_bysel(int dir, struct xfrm_selector *sel) {
   return __xfrm_policy_bysel(dir, sel, 0);
}


> -static int xfrm_del_policy(struct sk_buff *skb, struct nlmsghdr *nlh, void **xfrma)
> -{
:

> @@ -819,7 +815,7 @@
>  		.dump	=	xfrm_dump_sa,
>  	},
>  	{	.doit	=	xfrm_add_policy 	},
> -	{	.doit	=	xfrm_del_policy 	},
> +	{	.doit	=	xfrm_get_policy 	},
                                     ~~~delget or so
>  	{
>  		.doit	=	xfrm_get_policy,
                                     ~~~selget or so
>  		.dump	=	xfrm_dump_policy,

ditto...

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux