RE: [PATCH] Fix hard_use for xfrm_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David.

 >>     2. If x->curlft.use_time is non-zero, what do we return?
 >>        Nothing is specified in the actual statement.

 > It's a GCC extension, the following:
 >
 > 	a ? : b;
 >
 > is a shorthand for:
 >
 > 	a ? a : b;

If so, it's an extension that wants removing IMHO. It's certainly a
confusing shorthand as the obvious assumption for those not expecting
it (as I wasn't) is that it's shorthand for...

	a ? 0 : b;

...which bears no resemblance to what actually gets returned.

Best wishes from Riley.
---
 * Nothing as pretty as a smile, nothing as ugly as a frown.

---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.486 / Virus Database: 284 - Release Date: 29-May-2003

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux