From: Jonathan Wood <jonwood@speakeasy.net> Date: Thu, 15 May 2003 13:33:09 -0700 - x->type = xfrm_get_type(proto, x->props.family); + x->type = xfrm_get_type((uint8_t)proto, x->props.family); This change makes no sense. xfrm_get_type takes a "u8" as it's first argument, so the cast is occurring already anyways. Furthermore, proto is set by pfkey_satype2proto which always returns a value in the range of a "u8". I can only guess that you're getting a miscompile because of how little contextual information is included in your report. For example, what propted you to add this cast? What debugging did you see that led you to put this cast there? Why didn't you mention these issues of "why" when presenting this patch? - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
