Re: ipv6/ip6_fib.c DEBUG question

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ah, so it is.  Thanks for correcting me.

But the second check for obsolete still isn't needed, right?

It says (after negating inside the macro):

           if (obsolete) {
                   if (fn != NULL && obsolete > 0)
                           printk("assertion failed\n");

so it's redundant instead of impossible.

~Randy


> check the BUG_TRAP Macro , its something like this -
>
> #define BUG_TRAP(x) if (!(x)) {...}


Randy.Dunlap wrote:
>
> What/why this?
>
> #if RT6_DEBUG >= 2
>              if (rt->u.dst.obsolete>0) {
>                          BUG_TRAP(fn==NULL || rt->u.dst.obsolete<=0);
>                          return -ENOENT;
>              }
> #endif
>
> rt->u.dst.obsolete cannot be both > 0 and <= 0 !?!
> can it?
>
> --



-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux