> > Module unloading should be rare enough to tolerate > > the grace period under the module_mutex, right? > > > > Thoughts? > > I would agree. However can't unregister_snap_client be used in other paths > apart from module_unload? I wouldn't worry too much since if > register_snap_client and unregister_snap_client for the same protocol > races it's a bug in the caller's code. The safe RCU list removal and > synchronize_kernel should protect us from sane usage. > > Zwane It is not called from elsewhere right now, but if there is a possibility that it might be, Steve of course should keep the locking in these functions. Thanx, Paul - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html