From: Christoph Hellwig <hch@infradead.org> Date: Sun, 23 Feb 2003 10:02:34 +0000 > + icmp_xmit_lock(); Hmm, and I guess the code would be much more readable if you used the spin_lock call directly. The impliclit icmp_socket doesn't really help readability either. Sure it does, it encapsulates the icmp_socket->sk->foo->far->fum dereferencing into one place instead of 4. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html