Not calling start/stop queue from LKM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've inherited an LKM that implements a proprietary tunneling
protocol. I've noticed that it never calls any netif_*_queue()
routines. For example, the driver doesn't call start/stop queue
from its open/cose routines. I can understand not doing flow
control, since there's no physical device. I just want to make
sure the open/close logic is correct.

I could simply add the start/stop queue calls, but the driver
needs to be source-code compatible to both 2.2 and 2.4 kernel
streams. I'd rather not clutter it up with ifdefs if I don't have
to.

It seems to run fine. Do I leave it as-is or go to the trouble?

--
Gary Cote
Transat Technologies, Inc.

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux