Re: [PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Thu, Feb 13, 2003 at 07:23:20PM -0600, Art Haas escreveu:
> Hi.
> 
> Here's a patch that switches the file to use C99 initiailzers to aid
> readability and remove warings if '-W' is used.
> 
> +		.extra1		= &min_quality,
> +		.extra2		= &max_quality

Art, just a small nitpick: the "standard" in the kernel sources is for all
the members to have an ending comma, just like this:

> +		.extra1		= &min_quality,
> +		.extra2		= &max_quality,
                                              ^
                                              ^
                                              ^
So that when we need to add another member the patch gets smaller 8)

Aside from this small nitpick, keep it up the good work!

- Arnaldo
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux