Hi. Here's a patch for the file to convert it to use C99 initializers to aid readability and remove warnings if '-W' is used. Art Haas ===== net/rxrpc/sysctl.c 1.1 vs edited ===== --- 1.1/net/rxrpc/sysctl.c Tue Oct 8 02:58:33 2002 +++ edited/net/rxrpc/sysctl.c Thu Feb 13 19:12:56 2003 @@ -29,16 +29,50 @@ static struct ctl_table_header *rxrpc_sysctl = NULL; static ctl_table rxrpc_sysctl_table[] = { - { 1, "kdebug", &rxrpc_kdebug, sizeof(int), 0644, NULL, &proc_dointvec }, - { 2, "ktrace", &rxrpc_ktrace, sizeof(int), 0644, NULL, &proc_dointvec }, - { 3, "kproto", &rxrpc_kproto, sizeof(int), 0644, NULL, &proc_dointvec }, - { 4, "knet", &rxrpc_knet, sizeof(int), 0644, NULL, &proc_dointvec }, - { 0 } + { + .ctl_name = 1, + .procname = "kdebug", + .data = &rxrpc_kdebug, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = &proc_dointvec + }, + { + .ctl_name = 2, + .procname = "ktrace", + .data = &rxrpc_ktrace, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = &proc_dointvec + }, + { + .ctl_name = 3, + .procname = "kproto", + .data = &rxrpc_kproto, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = &proc_dointvec + }, + { + .ctl_name = 4, + .procname = "knet", + .data = &rxrpc_knet, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = &proc_dointvec + }, + { .ctl_name = 0 } }; static ctl_table rxrpc_dir_sysctl_table[] = { - { 1, "rxrpc", NULL, 0, 0555, rxrpc_sysctl_table }, - { 0 } + { + .ctl_name = 1, + .procname = "rxrpc", + .maxlen = 0, + .mode = 0555, + .child = rxrpc_sysctl_table + }, + { .ctl_name = 0 } }; #endif /* CONFIG_SYSCTL */ -- They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety. -- Benjamin Franklin, Historical Review of Pennsylvania, 1759 - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html