Re: [Question] Use of CONFIG_X86_TSC in pkt_sched.h and profile.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

> In pkt_sched.h, it appears PSCHED_CLOCK_SOURCE is always PSCHED_JIFFIES,
> so the CONFIG_X86_TSC'ed code under PSCHED_CPU is never even used. Would
> anyone object to dropping the PSCHED_CPU chunk?

This is the only working clock source for traffic control,
which is described in comments by the way. jiffies are useful only
for those who are interested only in plain bandwdth limiting.

And it was specially written _not_ to refer to arch/* at all
(and not to be visible in large config), so I even do not understand
how you managed to find this chunk of code, :-)


> The profile.h code is a bit more tricky because we toss around timeval
> but in some cases use them for the 64bit rdtscl values

Sorry? I do not understand about what kind of troubles you are speaking,
it uses elementary rdtsc, which returns two 32bit values. There are no
references to something 64bit in this code.

Alexey

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux