-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! On Tuesday 20 August 2002 01:24, Benjamin LaHaise wrote: > > I don't know much of your rules (shame on me), but my suggestion would > > be: > > > > - take the DP83840 symbols out of mii.h into drivers/net/sunmeh.h > > Well, put them in db83820.h surely. Yeah, I've considered to do this shortly before posting my last patch. But then I digged a little bit deeper and found some more inconsistencies regarding MII symbols. There is, for example, one DP83840-register already defined in sunhme.h. The same register is also defined in include/linux/dp83840.h. The Intel-eepro-driver uses one of the DP83840-registers out of mii.h and so on. Also there are some network drivers out there that seem to #define their own symbols. So *when* I would start to sort these symbols and do changes about that, it would include quite some changes to many existing drivers. But as I'm not so experienced to be sure these changes have no negative effect and do not have the possibility to test all these changed drivers, I decided to not fiddle around with these things. So I left mii.h completely unchanged in my last patch preferring to add a new header file lxt970.h for my purposes... - -- Ciao, Gernot -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9YfAHk997/GGeSeIRArMLAJwJEBTi1pVBP4b+BTfgMQfrWquA+QCeLr5x rqjH0TG4ecvry0z9IF37208= =+eTq -----END PGP SIGNATURE----- - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
