Re: [PATCH] Re: mii.h expansion for Level One LXT970 transceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gernot Hillier wrote:
> Hi!
> 
> On Thursday 08 August 2002 15:52, Gernot Hillier wrote:
> 
>>Hi!
>>
>>I'm currently working on epic100-fiber support for the SMC9432FTX-SC cards
>>using the LevelOne LXT970 transceiver (patch will follow in the next days).
>>
>>I now added the necessary symbols to include/linux/mii.h as I think this is
>>better then coding the magic numbers in epic100.c.
>>
>>I also made some little cosmetic changes to this file.
> 
> [...]
> 
> Sorry for the follow up, but I made a silly mistake. Please ignore the 
> FIXME-comment in the last patch. :-((
> 
> Correct patch attached. Please apply to include/linux/mii.h...


While the information does indeed look useful, we pretty much want to 
follow the standard rule of information visibility:  make symbols only 
as visible as they need to be.  Your initial comment indicates that the 
LXT970-specific symbols would be applicable to epic100.c.  If so, they 
should go in there.

The exception, of course, is that when these symbols would be needed in 
multiple .c files.  For that case, your patch would be correct.

Comments?

	Jeff




-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux