Re: [PATCH] PCI suspend/resume support to the 8139cp driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe W Damasio wrote:
> @@ -82,7 +82,7 @@
>  
>  /* These identify the driver base version and may not be removed. */
>  static char version[] __devinitdata =
> -KERN_INFO DRV_NAME ": 10/100 PCI Ethernet driver v" DRV_VERSION " (" DRV_RELDATE ")\n";
> +DRV_NAME ": 10/100 PCI Ethernet driver v" DRV_VERSION " (" DRV_RELDATE ")\n";


Why are you doing this?  You are moving the string concatenation from 
compile-time to runtime.

The main purpose of the this patch, PCI suspend/resume, looks ok :) 
This unrelated piece looks wrong.

	Jeff


-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux