Re: Don't use IP packets with payload < 8 octets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



   From: Morten Schlaeger <morten@ee.tu-berlin.de>
   Date: Wed, 9 Jan 2002 10:46:56 +0100 (CET)
   
   So, I think your statement is only true for the fragments of a fragmented
   packet. Further the appendix of RFC 791 gives the following example:

Man, if it weren't for RAW sockets I would be now asking
you "Now show me a legitimate IP packet that has one byte
of data".

Probably the correct test is therefore something like:

	if (ipprot_exists(iph->protocol) &&
	    pskb_may_pull(skb, ihl + 8))
		goto out;

And at that point this added overhead defeats the whole purpose of
consolidating the pskb_may_pull() from the protocol inputs, into
the generic IP input. :-(

So I'm going to ask anyways, what cool RAW sockets app uses these 1
byte packets?  :-)

Franks a lot,
David S. Miller
davem@redhat.com
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux